Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return binary data for application content types #414

Merged
merged 1 commit into from
May 7, 2019

Conversation

gp-greg
Copy link
Contributor

@gp-greg gp-greg commented Apr 18, 2019

This PR modifies the unmarshalling process to return raw_bytes when the content type is application. Per the spec this content type is used for data to be processed by an application before it is usable by a person, so I believe this is a safe change to make.

Original issue #394

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.841% when pulling 9d3ad1b on Greenphire:return_binary_for_app_types into 4fb2ba8 on Yelp:master.

@macisamuele macisamuele merged commit a5bc596 into Yelp:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants